docs(guide/dev): remove even more#360
Merged
KSXGitHub merged 1 commit intoMar 18, 2026
Merged
Conversation
Remove Visibility, Struct Field Ordering, Macros, and `pub use ... as` bullet — these are either standard Rust knowledge, generic best practices, or not used in the codebase. https://claude.ai/code/session_01VE5W68ky3UobBMongN8Dfc
Performance Regression Reportscommit: ab830ae There are no regressions. |
KSXGitHub
merged commit e04aedf
into
remove-some-parts-of-contribution-guide
13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes several outdated or overly prescriptive style guide sections from the CONTRIBUTING.md file that are no longer aligned with the project's current practices or philosophy.
Changes
pub use ... as ...for semantic alternative namespub,pub(crate), and private visibility guidelinesThese sections appear to have been superseded by more flexible or implicit conventions, and their removal simplifies the contributing guidelines while maintaining focus on the most important style considerations (derive macro ordering, error handling, etc.).
https://claude.ai/code/session_01VE5W68ky3UobBMongN8Dfc